linux-kernel - Re: [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Jul 2020 07:56:43 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        Iurii Zaikin <yzaikin@...gle.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Joe Perches <joe@...ches.com>
Subject: Re: [PATCH 16/23] seq_file: switch over direct seq_read method calls
 to seq_read_iter

On Thu, Jul 2, 2020 at 3:50 PM Christoph Hellwig <hch@....de> wrote:
>
> Do you have a suggestion for an automated replacement which does?
> I'll happily switch over to that.

I guess I'd simply find the unique set of cases that occur and create
a replacement for each manually. A handful of them or so may already
cover the majority of cases. CC'ing Joe since he deals with this sort
of stuff all the time.

Some cannot be handled with replacements, e.g. re-aligning the full
list is required to fit the longer `_iter` -- if you want to cover
those cases too, applying `clang-format` to the initializer may be a
good approach.

Cheers,
Miguel