[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <84068e20-9a34-6d03-61e6-6c243680749c@xs4all.nl>
Date: Fri, 3 Jul 2020 10:30:12 +0200
From: Hans Verkuil <hverkuil@...all.nl>
To: Alexandre Courbot <acourbot@...omium.org>,
Tiffany Lin <tiffany.lin@...iatek.com>,
Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
Rui Wang <gtk_ruiwang@...iatek.com>,
Yunfei Dong <yunfei.dong@...iatek.com>,
Pi-Hsun Shih <pihsun@...omium.org>,
Maoguang Meng <maoguang.meng@...iatek.com>
Cc: linux-media@...r.kernel.org, linux-mediatek@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 16/18] media: mtk-vcodec: venc: make S_PARM return
-ENOTTY for CAPTURE queue
On 26/06/2020 10:04, Alexandre Courbot wrote:
> v4l2-compliance expects ENOTTY to be returned when a given queue does
> not support S_PARM.
>
> Signed-off-by: Alexandre Courbot <acourbot@...omium.org>
> ---
> drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c
> index aae610e6d4e8..346a33c6869d 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c
> @@ -200,7 +200,7 @@ static int vidioc_venc_s_parm(struct file *file, void *priv,
> struct mtk_vcodec_ctx *ctx = fh_to_ctx(priv);
>
> if (a->type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
> - return -EINVAL;
> + return -ENOTTY;
This doesn't look right: S_PARM *is* supported, just not for this buffer type.
So -EINVAL is the correct error code.
What is the exact v4l2-compliance failure? It might be a bug in the test.
Regards,
Hans
>
> ctx->enc_params.framerate_num =
> a->parm.output.timeperframe.denominator;
>
Powered by blists - more mailing lists