linux-kernel - Re: [PATCH] scripts/Lindent: increase the maximum line length to 100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80902e5d0d5ef752e71672e9c5794d0f5f9ccd15.camel@perches.com>
Date:   Fri, 03 Jul 2020 01:51:51 -0700
From:   Joe Perches <joe@...ches.com>
To:     Zong Li <zong.li@...ive.com>, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org
Cc:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Subject: Re: [PATCH] scripts/Lindent: increase the maximum line length to 100

On Fri, 2020-07-03 at 16:08 +0800, Zong Li wrote:
> As the patch 'bdc48fa11e46 ("checkpatch/coding-style: deprecate
> 80-column warning")', increase the default limit to 100 characters,
> we also increase the maximum line length to 100 for indent script.

I'd prefer to delete Lindent instead.

Also any reformatting tool like this will
_always_ use up to whatever the maximum
line length is rather than use a preferred
length of 80 and and only use the allowed
maximum length of 100 when necessary for
human readability.

> Signed-off-by: Zong Li <zong.li@...ive.com>
> ---
>  scripts/Lindent | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Lindent b/scripts/Lindent
> index 1688c44c2df6..11f14a4f2048 100755
> --- a/scripts/Lindent
> +++ b/scripts/Lindent
> @@ -1,7 +1,7 @@
>  #!/bin/sh
>  # SPDX-License-Identifier: GPL-2.0
>  
> -PARAM="-npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1"
> +PARAM="-npro -kr -i8 -ts8 -sob -l100 -ss -ncs -cp1"
>  
>  RES=`indent --version | cut -d' ' -f3`
>  if [ "$RES" = "" ]; then