linux-kernel - [PATCH v2] kthread: work could not be queued when worker being destroyed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200702070156.5862-1-qiang.zhang@windriver.com>
Date:   Thu, 2 Jul 2020 15:01:56 +0800
From:   <qiang.zhang@...driver.com>
To:     <ben.dooks@...ethink.co.uk>, <bfields@...hat.com>,
        <cl@...k-chips.com>, <peterz@...radead.org>, <pmladek@...e.com>,
        <tj@...nel.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: [PATCH v2] kthread: work could not be queued when worker being destroyed

From: Zhang Qiang <qiang.zhang@...driver.com>

The "queuing_blocked" func should print warning message and
returns true when the worker being destroyed.

Suggested-by: Petr Mladek <pmladek@...e.com>
Signed-off-by: Zhang Qiang <qiang.zhang@...driver.com>
---
 v1->v2:
 Add warning information for condition "!worker->task"	

 kernel/kthread.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/kthread.c b/kernel/kthread.c
index bfbfa481be3a..cac5184ffd86 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -791,6 +791,9 @@ static inline bool queuing_blocked(struct kthread_worker *worker,
 {
 	lockdep_assert_held(&worker->lock);
 
+	if (WARN_ON(!worker->task))
+		return true;
+
 	return !list_empty(&work->node) || work->canceling;
 }
 
-- 
2.24.1