linux-kernel - Re: [PATCH v2] kthread: work could not be queued when worker being destroyed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200703111113.GG14288@alley>
Date:   Fri, 3 Jul 2020 13:11:13 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     qiang.zhang@...driver.com
Cc:     ben.dooks@...ethink.co.uk, bfields@...hat.com, cl@...k-chips.com,
        peterz@...radead.org, tj@...nel.org, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] kthread: work could not be queued when worker being
 destroyed

On Thu 2020-07-02 15:01:56, qiang.zhang@...driver.com wrote:
> From: Zhang Qiang <qiang.zhang@...driver.com>
> 
> The "queuing_blocked" func should print warning message and
> returns true when the worker being destroyed.
>
> Suggested-by: Petr Mladek <pmladek@...e.com>
> Signed-off-by: Zhang Qiang <qiang.zhang@...driver.com>

Looks good to me.

Reviewed-by: Petr Mladek <pmladek@...e.com>

Adding Andrew into CC. Changes in kernel/kthread.c usually goes
through him. You might need to resend the patch once again
with Andrew in CC.

Best Regards,
Petr Mladek