linux-kernel - Re: [PATCH 02/30] usb: host: pci-quirks: Demote function header from kerneldoc to comment block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Jul 2020 13:22:43 +0300
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     Lee Jones <lee.jones@...aro.org>, gregkh@...uxfoundation.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, Mathias Nyman <mathias.nyman@...el.com>,
        Martin Mares <mj@....cz>, aleksey_gorelov@...enix.com
Subject: Re: [PATCH 02/30] usb: host: pci-quirks: Demote function header from
 kerneldoc to comment block

On 2.7.2020 17.45, Lee Jones wrote:
> quirk_usb_handoff_xhci()'s function header is the only one across
> the sourcefile which is denoted as a kerneldoc header.  Despite
> no attempt to document its arguments.  Drop it down in status from
> kerneldoc to a standard comment block to match the other headers
> in the file.
> 
> Fixes the following W=1 kernel build warning:
> 
>  drivers/usb/host/pci-quirks.c:1145: warning: Function parameter or member 'pdev' not described in 'quirk_usb_handoff_xhci'
> 
> Cc: Mathias Nyman <mathias.nyman@...el.com>
> Cc: Martin Mares <mj@....cz>
> Cc: aleksey_gorelov@...enix.com
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Acked-by: Mathias Nyman <mathias.nyman@...ux.intel.com>