linux-kernel - Re: [PATCH] perf report TUI: Fix segmentation fault in perf_evsel__hists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200703115911.GE1320@kernel.org>
Date:   Fri, 3 Jul 2020 08:59:11 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     "liwei (GF)" <liwei391@...wei.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Jin Yao <yao.jin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>, guohanjun@...wei.com
Subject: Re: [PATCH] perf report TUI: Fix segmentation fault in
 perf_evsel__hists_browse()

Em Fri, Jul 03, 2020 at 09:03:53AM +0800, liwei (GF) escreveu:
> Ping...

Thanks, applied and tested, added the Acked-by Jiri and Namhyung
provided,

- Arnaldo
 
> On 2020/6/12 23:19, Namhyung Kim wrote:
> > Hello,
> > 
> > On Fri, Jun 12, 2020 at 6:58 PM Wei Li <liwei391@...wei.com> wrote:
> >>
> >> The segmentation fault can be reproduced as following steps:
> >> 1) Executing perf report in tui.
> >> 2) Typing '/xxxxx' to filter the symbol to get nothing matched.
> >> 3) Pressing enter with no entry selected.
> >> Then it will report a segmentation fault.
> >>
> >> It is caused by the lack of check of browser->he_selection when
> >> accessing it's member res_samples in perf_evsel__hists_browse().
> >>
> >> These processes are meaningful for specified samples, so we can
> >> skip these when nothing is selected.
> >>
> >> Fixes: 4968ac8fb7c3 ("perf report: Implement browsing of individual samples")
> >> Signed-off-by: Wei Li <liwei391@...wei.com>
> > 
> > Acked-by: Namhyung Kim <namhyung@...nel.org>
> > 
> > Thanks
> > Namhyung
> > 
> > 
> >> ---
> >>  tools/perf/ui/browsers/hists.c | 17 +++++++++++------
> >>  1 file changed, 11 insertions(+), 6 deletions(-)
> >>
> >> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> >> index 487e54ef56a9..2101b6b770d8 100644
> >> --- a/tools/perf/ui/browsers/hists.c
> >> +++ b/tools/perf/ui/browsers/hists.c
> >> @@ -2288,6 +2288,11 @@ static struct thread *hist_browser__selected_thread(struct hist_browser *browser
> >>         return browser->he_selection->thread;
> >>  }
> >>
> >> +static struct res_sample *hist_browser__selected_res_sample(struct hist_browser *browser)
> >> +{
> >> +       return browser->he_selection ? browser->he_selection->res_samples : NULL;
> >> +}
> >> +
> >>  /* Check whether the browser is for 'top' or 'report' */
> >>  static inline bool is_report_browser(void *timer)
> >>  {
> >> @@ -3357,16 +3362,16 @@ static int perf_evsel__hists_browse(struct evsel *evsel, int nr_events,
> >>                                              &options[nr_options], NULL, NULL, evsel);
> >>                 nr_options += add_res_sample_opt(browser, &actions[nr_options],
> >>                                                  &options[nr_options],
> >> -                                hist_browser__selected_entry(browser)->res_samples,
> >> -                                evsel, A_NORMAL);
> >> +                                                hist_browser__selected_res_sample(browser),
> >> +                                                evsel, A_NORMAL);
> >>                 nr_options += add_res_sample_opt(browser, &actions[nr_options],
> >>                                                  &options[nr_options],
> >> -                                hist_browser__selected_entry(browser)->res_samples,
> >> -                                evsel, A_ASM);
> >> +                                                hist_browser__selected_res_sample(browser),
> >> +                                                evsel, A_ASM);
> >>                 nr_options += add_res_sample_opt(browser, &actions[nr_options],
> >>                                                  &options[nr_options],
> >> -                                hist_browser__selected_entry(browser)->res_samples,
> >> -                                evsel, A_SOURCE);
> >> +                                                hist_browser__selected_res_sample(browser),
> >> +                                                evsel, A_SOURCE);
> >>                 nr_options += add_switch_opt(browser, &actions[nr_options],
> >>                                              &options[nr_options]);
> >>  skip_scripting:
> >> --
> >> 2.17.1
> >>

-- 

- Arnaldo