linux-kernel - Re: [PATCH v8 2/2] arm64: dts: sun50i-a64-pinephone: Add touchscreen support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200703121706.gf2yxfe7crleatlm@gilmour.lan>
Date:   Fri, 3 Jul 2020 14:17:06 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Ondrej Jirman <megous@...ous.com>
Cc:     Rob Herring <robh+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Icenowy Zheng <icenowy@...c.io>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Samuel Holland <samuel@...lland.org>,
        Martijn Braam <martijn@...xit.nl>, Luca Weiss <luca@...tu.xyz>,
        Bhushan Shah <bshah@....org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v8 2/2] arm64: dts: sun50i-a64-pinephone: Add touchscreen
 support

Hi,

On Thu, Jul 02, 2020 at 10:14:32AM +0200, Ondrej Jirman wrote:
> Pinephone has a Goodix GT917S capacitive touchscreen controller on
> I2C0 bus. Add support for it.
> 
> Signed-off-by: Ondrej Jirman <megous@...ous.com>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>  .../dts/allwinner/sun50i-a64-pinephone.dtsi   | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> index a89425ad3727..5c7386566053 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> @@ -121,6 +121,25 @@ &ehci1 {
>  	status = "okay";
>  };
>  
> +&i2c0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&i2c0_pins>;
> +	status = "okay";

I didn't spot this earlier, but the pinctrl properties are already set
in the DTSI. I've removed them while applying the patch.

Thanks!
Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)