[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200703130841.3zqa5y4uazzl477z@core.my.home>
Date: Fri, 3 Jul 2020 15:08:41 +0200
From: Ondřej Jirman <megous@...ous.com>
To: Maxime Ripard <maxime@...no.tech>
Cc: Rob Herring <robh+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
Icenowy Zheng <icenowy@...c.io>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
Samuel Holland <samuel@...lland.org>,
Martijn Braam <martijn@...xit.nl>, Luca Weiss <luca@...tu.xyz>,
Bhushan Shah <bshah@....org>,
Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v8 2/2] arm64: dts: sun50i-a64-pinephone: Add touchscreen
support
On Fri, Jul 03, 2020 at 02:17:06PM +0200, Maxime Ripard wrote:
> Hi,
>
> On Thu, Jul 02, 2020 at 10:14:32AM +0200, Ondrej Jirman wrote:
> > Pinephone has a Goodix GT917S capacitive touchscreen controller on
> > I2C0 bus. Add support for it.
> >
> > Signed-off-by: Ondrej Jirman <megous@...ous.com>
> > Acked-by: Linus Walleij <linus.walleij@...aro.org>
> > ---
> > .../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > index a89425ad3727..5c7386566053 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > @@ -121,6 +121,25 @@ &ehci1 {
> > status = "okay";
> > };
> >
> > +&i2c0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&i2c0_pins>;
> > + status = "okay";
>
> I didn't spot this earlier, but the pinctrl properties are already set
> in the DTSI. I've removed them while applying the patch.
Ah, right. Thank you very much. :)
regards,
o.
> Thanks!
> Maxime
Powered by blists - more mailing lists