linux-kernel - Re: [PATCH v3 3/3] drm/amdgpu: Change type of module param `ppfeaturemask` to hexint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Jul 2020 17:29:07 +0200
From:   Christian König <christian.koenig@....com>
To:     Paul Menzel <pmenzel@...gen.mpg.de>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Alex Deucher <alexander.deucher@....com>
Cc:     amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] drm/amdgpu: Change type of module param
 `ppfeaturemask` to hexint

Am 03.07.20 um 16:29 schrieb Paul Menzel:
> The newly added hexint helper is more convenient for bitmasks.
>
> Before:
>
>      $ more /sys/module/amdgpu/parameters/ppfeaturemask
>      4294950911
>
> After:
>
>      $ more /sys/module/amdgpu/parameters/ppfeaturemask
>      0xffffbfff
>
> Cc: amd-gfx@...ts.freedesktop.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Paul Menzel <pmenzel@...gen.mpg.de>

Reviewed-by: Christian König <christian.koenig@....com> for this one.

Feel free to add my Acked-by to the other two, but I'm not familiar 
enough with the code to review those.

Regards,
Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 126e74758a34..5c4263335cba 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -391,12 +391,12 @@ MODULE_PARM_DESC(sched_hw_submission, "the max number of HW submissions (default
>   module_param_named(sched_hw_submission, amdgpu_sched_hw_submission, int, 0444);
>   
>   /**
> - * DOC: ppfeaturemask (uint)
> + * DOC: ppfeaturemask (hexint)
>    * Override power features enabled. See enum PP_FEATURE_MASK in drivers/gpu/drm/amd/include/amd_shared.h.
>    * The default is the current set of stable power features.
>    */
>   MODULE_PARM_DESC(ppfeaturemask, "all power features enabled (default))");
> -module_param_named(ppfeaturemask, amdgpu_pp_feature_mask, uint, 0444);
> +module_param_named(ppfeaturemask, amdgpu_pp_feature_mask, hexint, 0444);
>   
>   /**
>    * DOC: forcelongtraining (uint)