linux-kernel - Re: [PATCH v3 3/3] drm/amdgpu: Change type of module param `ppfeaturemask` to hexint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e5b2284-0549-185c-4afd-f7d193e2faf9@molgen.mpg.de>
Date:   Thu, 23 Jul 2020 15:44:20 +0200
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Christian König <christian.koenig@....com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Alex Deucher <alexander.deucher@....com>
Cc:     amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] drm/amdgpu: Change type of module param
 `ppfeaturemask` to hexint

Dear Linus, dear Christian,


Am 03.07.20 um 17:29 schrieb Christian König:
> Am 03.07.20 um 16:29 schrieb Paul Menzel:
>> The newly added hexint helper is more convenient for bitmasks.
>>
>> Before:
>>
>>      $ more /sys/module/amdgpu/parameters/ppfeaturemask
>>      4294950911
>>
>> After:
>>
>>      $ more /sys/module/amdgpu/parameters/ppfeaturemask
>>      0xffffbfff
>>
>> Cc: amd-gfx@...ts.freedesktop.org
>> Cc: linux-kernel@...r.kernel.org
>> Signed-off-by: Paul Menzel <pmenzel@...gen.mpg.de>
> 
> Reviewed-by: Christian König <christian.koenig@....com> for this one.
> 
> Feel free to add my Acked-by to the other two, but I'm not familiar 
> enough with the code to review those.

Thank you. Sorry for being ignorant, but what is the way forward?


Kind regards,

Paul