[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <54ad054c-2cf4-765e-4ecc-44e2b98422f0@amd.com>
Date: Fri, 24 Jul 2020 09:54:17 +0200
From: Christian König <christian.koenig@....com>
To: Paul Menzel <pmenzel@...gen.mpg.de>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Alex Deucher <alexander.deucher@....com>
Cc: amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] drm/amdgpu: Change type of module param
`ppfeaturemask` to hexint
Am 23.07.20 um 15:44 schrieb Paul Menzel:
> Dear Linus, dear Christian,
>
>
> Am 03.07.20 um 17:29 schrieb Christian König:
>> Am 03.07.20 um 16:29 schrieb Paul Menzel:
>>> The newly added hexint helper is more convenient for bitmasks.
>>>
>>> Before:
>>>
>>> $ more /sys/module/amdgpu/parameters/ppfeaturemask
>>> 4294950911
>>>
>>> After:
>>>
>>> $ more /sys/module/amdgpu/parameters/ppfeaturemask
>>> 0xffffbfff
>>>
>>> Cc: amd-gfx@...ts.freedesktop.org
>>> Cc: linux-kernel@...r.kernel.org
>>> Signed-off-by: Paul Menzel <pmenzel@...gen.mpg.de>
>>
>> Reviewed-by: Christian König <christian.koenig@....com> for this one.
>>
>> Feel free to add my Acked-by to the other two, but I'm not familiar
>> enough with the code to review those.
>
> Thank you. Sorry for being ignorant, but what is the way forward?
Well, that's a very valid question. The general approach is that driver
changes are pushed upstream through the driver maintainers tree.
Since this driver change depends on a change in the general kernel an rb
from somebody who feels responsible for the code in the general kernel
might be a good idea.
But since you already addressed Linus comments and it looks rather clean
I think I can just push it to drm-misc-next on Monday if nobody objects
over the weekend.
Thanks for the help,
Christian.
>
>
> Kind regards,
>
> Paul
Powered by blists - more mailing lists