linux-kernel - Re: [PATCH 2/2] PM / devfreq: Add governor flags to clarify the features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 4 Jul 2020 05:34:11 +0900
From:   Chanwoo Choi <chanwoo@...nel.org>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Chanwoo Choi <cw00.choi@...sung.com>,
        Linux PM list <linux-pm@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Leonard Crestez <leonard.crestez@....com>, lukasz.luba@....com,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Lin Huang <hl@...k-chips.com>,
        Thierry Reding <thierry.reding@...il.com>,
        jonathanh@...dia.com, Abel Vesa <abel.vesa@....com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH 2/2] PM / devfreq: Add governor flags to clarify the features

Hi Dmitry,

On Fri, Jul 3, 2020 at 7:46 PM Dmitry Osipenko <digetx@...il.com> wrote:
>
> 03.07.2020 13:08, Chanwoo Choi пишет:
> > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> > index e94a27804c20..620ecd250d7c 100644
> > --- a/drivers/devfreq/tegra30-devfreq.c
> > +++ b/drivers/devfreq/tegra30-devfreq.c
> > @@ -765,10 +765,12 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
> >
> >  static struct devfreq_governor tegra_devfreq_governor = {
> >       .name = "tegra_actmon",
> > +     .flag = DEVFREQ_GOV_FLAG_ATTR_COMMON
> > +             | DEVFREQ_GOV_FLAG_ATTR_POLLING_INTERVAL,
>
> Hello, Chanwoo!
>
> There is a typo here, it should be ".attr = ".

Ah. Sorry. After changed the name, I didn't test COMPILE_TEST.

>
> > +     .flag = DEVFREQ_GOV_FLAG_FLAG_IMMUTABLE,
> > +             | DEVFREQ_GOV_FLAG_FLAG_IRQ_DRIVEN,
>
> There is a typo here too FLAG_FLAG ^

Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics