linux-kernel - Re: [PATCH 2/2] PM / devfreq: Add governor flags to clarify the features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6027cf29-ea6f-0a27-3e39-a80c24b80bb8@gmail.com>
Date:   Fri, 3 Jul 2020 13:46:30 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Chanwoo Choi <cw00.choi@...sung.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     leonard.crestez@....com, lukasz.luba@....com,
        enric.balletbo@...labora.com, hl@...k-chips.com,
        thierry.reding@...il.com, jonathanh@...dia.com, abel.vesa@....com,
        chanwoo@...nel.org, myungjoo.ham@...sung.com,
        kyungmin.park@...sung.com
Subject: Re: [PATCH 2/2] PM / devfreq: Add governor flags to clarify the
 features

03.07.2020 13:08, Chanwoo Choi пишет:
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index e94a27804c20..620ecd250d7c 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -765,10 +765,12 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
>  
>  static struct devfreq_governor tegra_devfreq_governor = {
>  	.name = "tegra_actmon",
> +	.flag = DEVFREQ_GOV_FLAG_ATTR_COMMON
> +		| DEVFREQ_GOV_FLAG_ATTR_POLLING_INTERVAL,

Hello, Chanwoo!

There is a typo here, it should be ".attr = ".

> +	.flag = DEVFREQ_GOV_FLAG_FLAG_IMMUTABLE,
> +		| DEVFREQ_GOV_FLAG_FLAG_IRQ_DRIVEN,

There is a typo here too FLAG_FLAG ^

>  	.get_target_freq = tegra_governor_get_target,
>  	.event_handler = tegra_governor_event_handler,
> -	.immutable = true,
> -	.interrupt_driven = true,
>  };
>