linux-kernel - Re: [PATCH 0/2] genirq: Kill preflow handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 04 Jul 2020 10:48:57 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Valentin Schneider <valentin.schneider@....com>
Cc:     linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>
Subject: Re: [PATCH 0/2] genirq: Kill preflow handlers

Hi Valentin,

On 2020-07-03 16:56, Valentin Schneider wrote:
> Hi,
> 
> while strolling around the different flow handlers, I tried to make 
> sense of
> what preflow_handler() was about. Turns out no one uses those anymore, 
> but the
> genirq support has remained in place.

If we needed to reintroduce some form of preflow handler, we'd try and
do it using hierarchical irqchips, if at all possible.

> 
> Unless we can see another user of those in the near future, this seems 
> like as
> good a time as any for a little housecleaning.
> 
> - Patch 1 simply deselects the (unexploited) preflow Kconfig for 
> sparc64
> - Patch 2 is the actual cleanup
> 
> Cheers,
> Valentin
> 
> Valentin Schneider (2):
>   sparc64: Deselect IRQ_PREFLOW_FASTEOI
>   genirq: Remove preflow handler support
> 
>  arch/sparc/Kconfig         |  1 -
>  include/linux/irqdesc.h    | 15 ---------------
>  include/linux/irqhandler.h |  1 -
>  kernel/irq/Kconfig         |  4 ----
>  kernel/irq/chip.c          | 13 -------------
>  5 files changed, 34 deletions(-)

For the whole series, and assuming that there is no regression
(can't imagine any for unused code):

Reviewed-by: Marc Zyngier <maz@...nel.org>

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...