linux-kernel - Re: [PATCH v2 2/2] i2c: fsi: Prevent adding adapters for ports without dts nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200704063918.GH1041@kunai>
Date:   Sat, 4 Jul 2020 08:39:18 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Eddie James <eajames@...ux.ibm.com>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        andy.shevchenko@...il.com, joel@....id.au
Subject: Re: [PATCH v2 2/2] i2c: fsi: Prevent adding adapters for ports
 without dts nodes

On Tue, Jun 09, 2020 at 03:15:55PM -0500, Eddie James wrote:
> Ports should be defined in the devicetree if they are to be enabled on
> the system.

The patch description does not really fit anymore, does it? There is no
change in behaviour, we just remove a redundant check.

> 
> Signed-off-by: Eddie James <eajames@...ux.ibm.com>
> Signed-off-by: Joel Stanley <joel@....id.au>
> ---
> Changes since v1:
>  - Remove the check for null device node since that is checked in
>    of_device_is_available
> 
>  drivers/i2c/busses/i2c-fsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-fsi.c b/drivers/i2c/busses/i2c-fsi.c
> index 977d6f524649..10332693edf0 100644
> --- a/drivers/i2c/busses/i2c-fsi.c
> +++ b/drivers/i2c/busses/i2c-fsi.c
> @@ -703,7 +703,7 @@ static int fsi_i2c_probe(struct device *dev)
>  
>  	for (port_no = 0; port_no < ports; port_no++) {
>  		np = fsi_i2c_find_port_of_node(dev->of_node, port_no);
> -		if (np && !of_device_is_available(np))
> +		if (!of_device_is_available(np))
>  			continue;
>  
>  		port = kzalloc(sizeof(*port), GFP_KERNEL);
> -- 
> 2.24.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)