linux-kernel - Re: [PATCH] exfat: implement "quiet" option for setattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD14+f0QUgXbDY8vK4HHKcWAh90Jp8DCMb-SRoFmmGrZ3cBhdw@mail.gmail.com>
Date:   Mon, 6 Jul 2020 17:22:40 +0900
From:   Ju Hyung Park <qkrwngud825@...il.com>
To:     Namjae Jeon <namjae.jeon@...sung.com>
Cc:     Sungjong Seo <sj1557.seo@...sung.com>,
        open list <linux-kernel@...r.kernel.org>,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] exfat: implement "quiet" option for setattr

Hi Namjae.

Looks like I ported this incorrectly from the previous sdFAT base.

I'll fix, test again and send v2.

Thanks.

On Thu, Jul 2, 2020 at 2:16 PM Namjae Jeon <namjae.jeon@...sung.com> wrote:
>
> >
> >       if (((attr->ia_valid & ATTR_UID) &&
> >            !uid_eq(attr->ia_uid, sbi->options.fs_uid)) || @@ -322,6 +325,12 @@ int
> > exfat_setattr(struct dentry *dentry, struct iattr *attr)
> >               goto out;
> You should remove goto statement and curly braces here to reach if error condition.
> >       }
> >
> > +     if (error) {
> > +             if (sbi->options.quiet)
> > +                     error = 0;
> > +             goto out;
> > +     }
>