linux-kernel - Re: [PATCH] exfat: implement "quiet" option for setattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd-49hN3CVzeQBa6MqiY36yc7mmn4FkVHABeBvakWYyU8Q@mail.gmail.com>
Date:   Mon, 6 Jul 2020 19:26:37 +0900
From:   Namjae Jeon <linkinjeon@...nel.org>
To:     Ju Hyung Park <qkrwngud825@...il.com>
Cc:     Namjae Jeon <namjae.jeon@...sung.com>,
        Sungjong Seo <sj1557.seo@...sung.com>,
        open list <linux-kernel@...r.kernel.org>,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] exfat: implement "quiet" option for setattr

2020-07-06 17:22 GMT+09:00, Ju Hyung Park <qkrwngud825@...il.com>:
> Hi Namjae.
Hi Juhyung,
>
> Looks like I ported this incorrectly from the previous sdFAT base.
>
> I'll fix, test again and send v2.
Okay:) Thanks!
>
> Thanks.
>
> On Thu, Jul 2, 2020 at 2:16 PM Namjae Jeon <namjae.jeon@...sung.com> wrote:
>>
>> >
>> >       if (((attr->ia_valid & ATTR_UID) &&
>> >            !uid_eq(attr->ia_uid, sbi->options.fs_uid)) || @@ -322,6
>> > +325,12 @@ int
>> > exfat_setattr(struct dentry *dentry, struct iattr *attr)
>> >               goto out;
>> You should remove goto statement and curly braces here to reach if error
>> condition.
>> >       }
>> >
>> > +     if (error) {
>> > +             if (sbi->options.quiet)
>> > +                     error = 0;
>> > +             goto out;
>> > +     }
>>
>