linux-kernel - Re: [PATCH] media: cros-ec-cec: disable the device wakeup on remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200706090056.GI6538@piout.net>
Date:   Mon, 6 Jul 2020 11:00:56 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Dariusz Marcinkiewicz <darekm@...gle.com>
Cc:     linux-media@...r.kernel.org, hverkuil-cisco@...all.nl,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Dariusz Marcinkiewicz <darekm@...omium.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: cros-ec-cec: disable the device wakeup on remove

On 06/07/2020 10:52:38+0200, Dariusz Marcinkiewicz wrote:
> The device is enabled for wake up while the driver is loaded.
> For symmetry, disable wakeup when it is removed.
> 

This is not necessary as it is handled by the core properly. There are
currently 73 calls to device_init_wakeup that are not necessary, this
would add one more.

> Signed-off-by: Dariusz Marcinkiewicz <darekm@...gle.com>
> ---
>  drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> index 2d95e16cd248..3881ed7bc3d9 100644
> --- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> +++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> @@ -277,8 +277,6 @@ static int cros_ec_cec_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, cros_ec_cec);
>  	cros_ec_cec->cros_ec = cros_ec;
>  
> -	device_init_wakeup(&pdev->dev, 1);
> -
>  	cros_ec_cec->adap = cec_allocate_adapter(&cros_ec_cec_ops, cros_ec_cec,
>  						 DRV_NAME,
>  						 CEC_CAP_DEFAULTS |
> @@ -306,6 +304,8 @@ static int cros_ec_cec_probe(struct platform_device *pdev)
>  	if (ret < 0)
>  		goto out_probe_notify;
>  
> +	device_init_wakeup(&pdev->dev, 1);
> +
>  	return 0;
>  
>  out_probe_notify:
> @@ -335,6 +335,8 @@ static int cros_ec_cec_remove(struct platform_device *pdev)
>  					 cros_ec_cec->adap);
>  	cec_unregister_adapter(cros_ec_cec->adap);
>  
> +	device_init_wakeup(&pdev->dev, 0);
> +
>  	return 0;
>  }
>  
> -- 
> 2.27.0.212.ge8ba1cc988-goog
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com