linux-kernel - Re: [PATCH 08/32] usb: typec: tcpm: tcpm: Remove dangling unused 'struct tcpm_altmode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Jul 2020 15:20:51 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     gregkh@...uxfoundation.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        Guenter Roeck <linux@...ck-us.net>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH 08/32] usb: typec: tcpm: tcpm: Remove dangling unused
 'struct tcpm_altmode_ops'

On Mon, 06 Jul 2020, Hans de Goede wrote:

> Hi,
> 
> On 7/6/20 3:33 PM, Lee Jones wrote:
> > Looks as though a079973f462a3 ("usb: typec: tcpm: Remove tcpc_config
> > configuration mechanism") pulled out the only use of 'tcpm_altmode_ops'
> > last year.  No need to keep it around.
> > 
> > Fixes the following W=1 kernel build warning(s):
> > 
> >   drivers/usb/typec/tcpm/tcpm.c:1551:39: warning: ‘tcpm_altmode_ops’ defined but not used [-Wunused-const-variable=]
> >   1551 | static const struct typec_altmode_ops tcpm_altmode_ops = {
> >   | ^~~~~~~~~~~~~~~~
> > 
> > Cc: Guenter Roeck <linux@...ck-us.net>
> > Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> > Cc: Hans de Goede <hdegoede@...hat.com>
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> 
> This is necessary for adding Display port over Type-C support
> on devices using the tcpm code, rather then firmware, to do
> the Type-C alt-mode negotiation.
> 
> I have a local patch in my tree which adds support for this.
> 
> But Heikki did not like my approach, so that patch
> (which needs the bits you are removing) never landed
> upstream:
> 
> https://patchwork.kernel.org/patch/11199517/
> 
> Which is somewhat old now.

Yes, that's a just a little old now.

If it drags on for much longer, perhaps consider taking it out for the
time being and adding it back when you start to make use of it again?

> Heikki said he would look into an approach to this more to
> his liking. Heikki an progress on this area?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog