[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJe_ZheZY-Vc+bZGGHKM7YkBxoOyf3CPBHY0=+cTw5Pp69FqEg@mail.gmail.com>
Date: Mon, 6 Jul 2020 11:08:25 -0500
From: Jassi Brar <jaswinder.singh@...aro.org>
To: Lee Jones <lee.jones@...aro.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-arm-kernel@...ts.infradead.org,
lkml <linux-kernel@...r.kernel.org>,
Linux USB list <linux-usb@...r.kernel.org>,
Felipe Balbi <balbi@...nel.org>,
Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH 23/32] usb: gadget: udc: max3420_udc: Remove set, but
never checked variable 'addr'
On Mon, 6 Jul 2020 at 08:34, Lee Jones <lee.jones@...aro.org> wrote:
> diff --git a/drivers/usb/gadget/udc/max3420_udc.c b/drivers/usb/gadget/udc/max3420_udc.c
> index 23f33946d80c4..52884bae4af11 100644
> --- a/drivers/usb/gadget/udc/max3420_udc.c
> +++ b/drivers/usb/gadget/udc/max3420_udc.c
> @@ -623,7 +623,6 @@ static void max3420_set_clear_feature(struct max3420_udc *udc)
> static void max3420_handle_setup(struct max3420_udc *udc)
> {
> struct usb_ctrlrequest setup;
> - u8 addr;
>
> spi_rd_buf(udc, MAX3420_REG_SUDFIFO, (void *)&setup, 8);
>
> @@ -647,7 +646,7 @@ static void max3420_handle_setup(struct max3420_udc *udc)
> USB_TYPE_STANDARD | USB_RECIP_DEVICE)) {
> break;
> }
> - addr = spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1);
> + spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1);
> dev_dbg(udc->dev, "Assigned Address=%d\n", udc->setup.wValue);
> return;
> case USB_REQ_CLEAR_FEATURE:
Acked-by: Jassi Brar <jaswinder.singh@...aro.org>
Powered by blists - more mailing lists