linux-kernel - Re: [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87imf0mvk7.fsf@x220.int.ebiederm.org>
Date:   Mon, 06 Jul 2020 11:56:24 -0500
From:   ebiederm@...ssion.com (Eric W. Biederman)
To:     Lee Jones <lee.jones@...aro.org>
Cc:     gregkh@...uxfoundation.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        Sumit Garg <sumit.garg@...aro.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Douglas Anderson <dianders@...omium.org>,
        Petr Mladek <pmladek@...e.com>,
        Yinghai Lu <yhlu.kernel@...il.com>,
        Jason Wessel <jason.wessel@...driver.com>
Subject: Re: [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret'

Lee Jones <lee.jones@...aro.org> writes:

> 'ret' hasn't  been checked since the driver's inception in 2009.

Minor quibble the inception was in 5c05917e7fe3 ("x86: usb debug port
early console, v4") in July of 2008.

Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>

> Fixes the following W=1 kernel build warning(s):
>
>  drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’:
>  drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>  915 | int chunk, ret;
>  | ^~~
>
> Cc: Sumit Garg <sumit.garg@...aro.org>
> Cc: Daniel Thompson <daniel.thompson@...aro.org>
> Cc: Douglas Anderson <dianders@...omium.org>
> Cc: Petr Mladek <pmladek@...e.com>
> Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
> Cc: Yinghai Lu <yhlu.kernel@...il.com>
> Cc: Jason Wessel <jason.wessel@...driver.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/usb/early/ehci-dbgp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/early/ehci-dbgp.c b/drivers/usb/early/ehci-dbgp.c
> index 775cf70cfb3ed..b075dbfad730f 100644
> --- a/drivers/usb/early/ehci-dbgp.c
> +++ b/drivers/usb/early/ehci-dbgp.c
> @@ -912,7 +912,7 @@ int __init early_dbgp_init(char *s)
>  
>  static void early_dbgp_write(struct console *con, const char *str, u32 n)
>  {
> -	int chunk, ret;
> +	int chunk;
>  	char buf[DBGP_MAX_PACKET];
>  	int use_cr = 0;
>  	u32 cmd, ctrl;
> @@ -951,8 +951,8 @@ static void early_dbgp_write(struct console *con, const char *str, u32 n)
>  			buf[chunk] = *str;
>  		}
>  		if (chunk > 0) {
> -			ret = dbgp_bulk_write(USB_DEBUG_DEVNUM,
> -				      dbgp_endpoint_out, buf, chunk);
> +			dbgp_bulk_write(USB_DEBUG_DEVNUM,
> +					dbgp_endpoint_out, buf, chunk);
>  		}
>  	}
>  	if (unlikely(reset_run)) {