linux-kernel - Re: [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200706175733.GB3500@dell>
Date:   Mon, 6 Jul 2020 18:57:33 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     gregkh@...uxfoundation.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        Sumit Garg <sumit.garg@...aro.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Douglas Anderson <dianders@...omium.org>,
        Petr Mladek <pmladek@...e.com>,
        Yinghai Lu <yhlu.kernel@...il.com>,
        Jason Wessel <jason.wessel@...driver.com>
Subject: Re: [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never
 checked variable 'ret'

On Mon, 06 Jul 2020, Eric W. Biederman wrote:

> Lee Jones <lee.jones@...aro.org> writes:
> 
> > 'ret' hasn't  been checked since the driver's inception in 2009.
> 
> Minor quibble the inception was in 5c05917e7fe3 ("x86: usb debug port
> early console, v4") in July of 2008.

I'm only going back as far as the inception of ehci-dbgp.c.

> Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Great, thanks.

> > Fixes the following W=1 kernel build warning(s):
> >
> >  drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’:
> >  drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
> >  915 | int chunk, ret;
> >  | ^~~
> >
> > Cc: Sumit Garg <sumit.garg@...aro.org>
> > Cc: Daniel Thompson <daniel.thompson@...aro.org>
> > Cc: Douglas Anderson <dianders@...omium.org>
> > Cc: Petr Mladek <pmladek@...e.com>
> > Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
> > Cc: Yinghai Lu <yhlu.kernel@...il.com>
> > Cc: Jason Wessel <jason.wessel@...driver.com>
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > ---
> >  drivers/usb/early/ehci-dbgp.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog