linux-kernel - Re: [EXTERNAL] Re: [PATCH v15 2/4] dt-bindings: power: Convert battery.txt to battery.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Jul 2020 13:45:24 -0500
From:   Ricardo Rivera-Matos <r-rivera-matos@...com>
To:     Rob Herring <robh@...nel.org>
CC:     <pali@...nel.org>, <linux-pm@...r.kernel.org>,
        <sspatil@...roid.com>, <linux-kernel@...r.kernel.org>,
        <afd@...com>, <dmurphy@...com>, <sre@...nel.org>,
        <devicetree@...r.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH v15 2/4] dt-bindings: power: Convert
 battery.txt to battery.yaml

Rob

On 7/2/20 3:53 PM, Rob Herring wrote:
> On Wed, 01 Jul 2020 16:10:42 -0500, Ricardo Rivera-Matos wrote:
>> From: Dan Murphy <dmurphy@...com>
>>
>> Convert the battery.txt file to yaml and fix up the examples.
>>
>> Signed-off-by: Dan Murphy <dmurphy@...com>
>> ---
>>   .../bindings/power/supply/battery.txt         |  86 +---------
>>   .../bindings/power/supply/battery.yaml        | 157 ++++++++++++++++++
>>   2 files changed, 158 insertions(+), 85 deletions(-)
>>   create mode 100644 Documentation/devicetree/bindings/power/supply/battery.yaml
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.6/dist-packages/dtschema/schema/types.yaml'
> Documentation/devicetree/bindings/Makefile:20: recipe for target 'Documentation/devicetree/bindings/power/supply/battery.example.dts' failed
> make[1]: *** [Documentation/devicetree/bindings/power/supply/battery.example.dts] Error 255
> make[1]: *** Waiting for unfinished jobs....
> Makefile:1347: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
I think your bot is looking for the types.yaml in the wrong place. 
'/usr/local/lib/python3.6/dist-packages/dtschema/schema/types.yaml' 
should be 
'/usr/local/lib/python3.6/dist-packages/dtschema/schemas/types.yaml'. I 
renamed might 'schemas' directory to 'schema' and my battery.yaml passed 
the dt_binding_check.
>
>
> See https://patchwork.ozlabs.org/patch/1320813
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
>
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Confirmed on latest dt-schema
>
> Please check and re-submit.

     Thanks,

         Ricardo

>