linux-kernel - Re: [EXTERNAL] Re: [PATCH v15 2/4] dt-bindings: power: Convert battery.txt to battery.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Jul 2020 08:40:20 -0600
From:   Rob Herring <robh@...nel.org>
To:     Ricardo Rivera-Matos <r-rivera-matos@...com>
Cc:     Pali Rohár <pali@...nel.org>,
        "open list:THERMAL" <linux-pm@...r.kernel.org>,
        Sandeep Patil <sspatil@...roid.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Andrew F. Davis" <afd@...com>, Dan Murphy <dmurphy@...com>,
        Sebastian Reichel <sre@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [EXTERNAL] Re: [PATCH v15 2/4] dt-bindings: power: Convert
 battery.txt to battery.yaml

On Mon, Jul 6, 2020 at 12:45 PM Ricardo Rivera-Matos
<r-rivera-matos@...com> wrote:
>
> Rob
>
> On 7/2/20 3:53 PM, Rob Herring wrote:
> > On Wed, 01 Jul 2020 16:10:42 -0500, Ricardo Rivera-Matos wrote:
> >> From: Dan Murphy <dmurphy@...com>
> >>
> >> Convert the battery.txt file to yaml and fix up the examples.
> >>
> >> Signed-off-by: Dan Murphy <dmurphy@...com>
> >> ---
> >>   .../bindings/power/supply/battery.txt         |  86 +---------
> >>   .../bindings/power/supply/battery.yaml        | 157 ++++++++++++++++++
> >>   2 files changed, 158 insertions(+), 85 deletions(-)
> >>   create mode 100644 Documentation/devicetree/bindings/power/supply/battery.yaml
> >>
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.6/dist-packages/dtschema/schema/types.yaml'
> > Documentation/devicetree/bindings/Makefile:20: recipe for target 'Documentation/devicetree/bindings/power/supply/battery.example.dts' failed
> > make[1]: *** [Documentation/devicetree/bindings/power/supply/battery.example.dts] Error 255
> > make[1]: *** Waiting for unfinished jobs....
> > Makefile:1347: recipe for target 'dt_binding_check' failed
> > make: *** [dt_binding_check] Error 2
> I think your bot is looking for the types.yaml in the wrong place.

Really? Yet it works fine on thousands of other patches?

> '/usr/local/lib/python3.6/dist-packages/dtschema/schema/types.yaml'
> should be
> '/usr/local/lib/python3.6/dist-packages/dtschema/schemas/types.yaml'. I
> renamed might 'schemas' directory to 'schema' and my battery.yaml passed
> the dt_binding_check.

Maybe fix the 'schema/' path in your schema file which is wrong.

Rob