linux-kernel - Re: [PATCH] input/synaptics: enable InterTouch for ThinkPad X1E 1st gen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1295871594063151@mail.yandex.ru>
Date:   Mon, 06 Jul 2020 22:20:47 +0300
From:   Ilya K <me@...ti.me>
To:     "lyude@...hat.com" <lyude@...hat.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Gaurav Agrawal <agrawalgaurav@...me.org>,
        Yussuf Khalil <dev@...345.net>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Dennis Kadioglu <denk@...ipso.email>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Joe Perches <joe@...ches.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] input/synaptics: enable InterTouch for ThinkPad X1E 1st gen

(sorry for resending - the previous message got sent as HTML and bounced off the mailing list)

This actually made me retest it just now - it most definitely works, both by tapping and by actually clicking the button.

06.07.2020, 20:22, "Lyude Paul" <lyude@...hat.com>:
> FWIW it's not placebo, it's why I always immediately notice when starting up a
> new ThinkPad sample from lenovo if RMI4 is enabled or not :).
>
> Anyway thank you for the patch, assuming you double-checked that clicking with
> the clickpad still works (I made this mistake last time when trying to enable
> this for the second generation X1 extreme):
>
> Reviewed-by: Lyude Paul <lyude@...hat.com>
>
> On Fri, 2020-07-03 at 17:34 +0300, K900 wrote:
>>  From: Ilya Katsnelson <me@...ti.me>
>>
>>  Tested on my own laptop, touchpad feels slightly more responsive with
>>  this on, though it might just be placebo.
>>
>>  Signed-off-by: Ilya Katsnelson <me@...ti.me>
>>  ---
>>   drivers/input/mouse/synaptics.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>>  diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
>>  index 758dae8d6500..4b81b2d0fe06 100644
>>  --- a/drivers/input/mouse/synaptics.c
>>  +++ b/drivers/input/mouse/synaptics.c
>>  @@ -179,6 +179,7 @@ static const char * const smbus_pnp_ids[] = {
>>           "LEN0093", /* T480 */
>>           "LEN0096", /* X280 */
>>           "LEN0097", /* X280 -> ALPS trackpoint */
>>  + "LEN0099", /* X1 Extreme 1st */
>>           "LEN009b", /* T580 */
>>           "LEN200f", /* T450s */
>>           "LEN2044", /* L470 */