linux-kernel - Re: [PATCH net-next 02/12] bridge: uapi: mrp: Extend MRP attributes for MRP interconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200706.122748.828248704525141203.davem@davemloft.net>
Date:   Mon, 06 Jul 2020 12:27:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     horatiu.vultur@...rochip.com
Cc:     nikolay@...ulusnetworks.com, roopa@...ulusnetworks.com,
        kuba@...nel.org, jiri@...nulli.us, ivecera@...hat.com,
        andrew@...n.ch, UNGLinuxDriver@...rochip.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next 02/12] bridge: uapi: mrp: Extend MRP
 attributes for MRP interconnect

From: Horatiu Vultur <horatiu.vultur@...rochip.com>
Date: Mon, 6 Jul 2020 11:18:32 +0200

> +struct br_mrp_in_state {
> +	__u16 in_id;
> +	__u32 in_state;
> +};

Put the __u32 first then the __u16.

> +struct br_mrp_in_role {
> +	__u16 in_id;
> +	__u32 ring_id;
> +	__u32 in_role;
> +	__u32 i_ifindex;
> +};

Likewise.

> +struct br_mrp_start_in_test {
> +	__u16 in_id;
> +	__u32 interval;
> +	__u32 max_miss;
> +	__u32 period;
> +};

Likewise.

> +struct br_mrp_in_test_hdr {
> +	__be16 id;
> +	__u8 sa[ETH_ALEN];
> +	__be16 port_role;
> +	__be16 state;
> +	__be16 transitions;
> +	__be32 timestamp;
> +};

Likewise.  Put the larger members first.  There is lots of unnecessary
padding in this structure.