[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 7 Jul 2020 19:59:44 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Lee Jones <lee.jones@...aro.org>
Cc: Mark Brown <broonie@...nel.org>,
Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
ALSA Development Mailing List <alsa-devel@...a-project.org>
Subject: Re: [PATCH 17/28] ASoC: uniphier: aio-core: Fix incorrectly named
struct property and remove another
On Tue, Jul 7, 2020 at 7:18 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> Both issues are likely due to bitrot. Let's bring them up-to-date.
>
> Fixes the following W=1 kernel build warning(s):
>
> sound/soc/uniphier/aio-core.c:107: warning: Function parameter or member 'pll_id' not described in 'aio_chip_set_pll'
> sound/soc/uniphier/aio-core.c:107: warning: Excess function parameter 'source' description in 'aio_chip_set_pll'
> sound/soc/uniphier/aio-core.c:279: warning: Excess function parameter 'ch' description in 'aio_port_set_ch'
>
> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
Reviewed-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
but Pierre-Louis Bossart had already sent an equivalent patch.
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
> sound/soc/uniphier/aio-core.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/uniphier/aio-core.c b/sound/soc/uniphier/aio-core.c
> index 9bcba06ba52ea..86eb0915d80ad 100644
> --- a/sound/soc/uniphier/aio-core.c
> +++ b/sound/soc/uniphier/aio-core.c
> @@ -93,9 +93,9 @@ void aio_iecout_set_enable(struct uniphier_aio_chip *chip, bool enable)
>
> /**
> * aio_chip_set_pll - set frequency to audio PLL
> - * @chip : the AIO chip pointer
> - * @source: PLL
> - * @freq : frequency in Hz, 0 is ignored
> + * @chip: the AIO chip pointer
> + * @pll_id: PLL
> + * @freq: frequency in Hz, 0 is ignored
> *
> * Sets frequency of audio PLL. This function can be called anytime,
> * but it takes time till PLL is locked.
> @@ -267,7 +267,6 @@ void aio_port_reset(struct uniphier_aio_sub *sub)
> /**
> * aio_port_set_ch - set channels of LPCM
> * @sub: the AIO substream pointer, PCM substream only
> - * @ch : count of channels
> *
> * Set suitable slot selecting to input/output port block of AIO.
> *
> --
> 2.25.1
>
--
Best Regards
Masahiro Yamada
Powered by blists - more mailing lists