[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 7 Jul 2020 13:48:34 +0300
From: Peter Ujfalusi <peter.ujfalusi@...com>
To: Lee Jones <lee.jones@...aro.org>, <broonie@...nel.org>,
<lgirdwood@...il.com>, <perex@...ex.cz>, <tiwai@...e.com>
CC: <linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <alsa-devel@...a-project.org>,
Jarkko Nikula <jarkko.nikula@...mer.com>,
Samuel Ortiz <samuel.ortiz@...ia.com>,
<linux-omap@...r.kernel.org>
Subject: Re: [PATCH 21/28] ASoC: ti: omap-mcbsp-st: Remove set, but unused
variable 'w'
Hi Lee,
On 07/07/2020 13.16, Lee Jones wrote:
> Looks like 'w' has remained unchecked since the driver's inception.
>
> Fixes the following W=1 kernel build warning(s):
>
> sound/soc/ti/omap-mcbsp-st.c: In function ‘omap_mcbsp_st_chgain’:
> sound/soc/ti/omap-mcbsp-st.c:145:6: warning: variable ‘w’ set but not used [-Wunused-but-set-variable]
>
> Cc: Peter Ujfalusi <peter.ujfalusi@...com>
> Cc: Jarkko Nikula <jarkko.nikula@...mer.com>
> Cc: Samuel Ortiz <samuel.ortiz@...ia.com>
> Cc: linux-omap@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
> sound/soc/ti/omap-mcbsp-st.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/ti/omap-mcbsp-st.c b/sound/soc/ti/omap-mcbsp-st.c
> index 5a32b54bbf3bb..643ef7eb68fc8 100644
> --- a/sound/soc/ti/omap-mcbsp-st.c
> +++ b/sound/soc/ti/omap-mcbsp-st.c
> @@ -142,10 +142,9 @@ static void omap_mcbsp_st_fir_write(struct omap_mcbsp *mcbsp, s16 *fir)
>
> static void omap_mcbsp_st_chgain(struct omap_mcbsp *mcbsp)
> {
> - u16 w;
> struct omap_mcbsp_st_data *st_data = mcbsp->st_data;
>
> - w = MCBSP_ST_READ(mcbsp, SSELCR);
> + MCBSP_ST_READ(mcbsp, SSELCR);
The read can be removed at the same time.
> MCBSP_ST_WRITE(mcbsp, SGAINCR, ST_CH0GAIN(st_data->ch0gain) |
> ST_CH1GAIN(st_data->ch1gain));
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Powered by blists - more mailing lists