[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 7 Jul 2020 15:52:57 +0200
From: Christian Brauner <christian.brauner@...ntu.com>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
christian@...uner.io, shuah@...nel.org
Subject: Re: [PATCH v3 0/2] selftests: pidfd: prefer ksft_test_result_skip to
ksft_exit_*
On Tue, Jul 07, 2020 at 06:19:34AM -0400, Paolo Bonzini wrote:
> Calling ksft_exit_* results in executing fewer tests than planned, which
> is wrong for ksft_exit_skip or suboptimal (because it results in a bail
> out) for ksft_exit_fail_msg.
>
> Using ksft_test_result_skip instead skips only one test and lets the
> test plan proceed as promised by ksft_set_plan.
>
> Paolo
Thanks for fixing this, Paolo!
Acked-by: Christian Brauner <christian.brauner@...ntu.com>
Shuah, want me to take it or do you want to take it?
Powered by blists - more mailing lists