linux-kernel - Re: [PATCH 11/11] media: exynos4-is: Correct parallel port probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05381b4a-3581-e57d-3ecc-43eaafd9d527@samsung.com>
Date:   Wed, 8 Jul 2020 18:15:05 +0200
From:   Sylwester Nawrocki <s.nawrocki@...sung.com>
To:     Jonathan Bakker <xc-racer2@...e.ca>, kyungmin.park@...sung.com,
        mchehab@...nel.org, kgene@...nel.org, krzk@...nel.org,
        linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/11] media: exynos4-is: Correct parallel port probing

Hi,

On 26.04.2020 04:26, Jonathan Bakker wrote:
> According to the binding doc[1], port A should be reg = 0
> and port B reg = 1.  Unfortunately, the driver was treating 0
> as invalid and 1 as camera port A.  Match the binding doc and
> make 0=A and 1=B.
> 
> [1] Documentation/devicetree/bindings/media/samsung-fimc.txt

Thank you for correcting this. I would prefer to correct the binding
documentation instead, so it says reg=1 for A and reg=2 for B. 
Then it would also match what we have in dts for Goni and 
enum fimc_input in include/media/drv-intf/exynos-fimc.h.


-- 
Regards,
Sylwester