[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <BN6PR04MB0660D832F51C14CD10257B9EA3620@BN6PR04MB0660.namprd04.prod.outlook.com>
Date: Sat, 11 Jul 2020 11:18:46 -0700
From: Jonathan Bakker <xc-racer2@...e.ca>
To: Sylwester Nawrocki <s.nawrocki@...sung.com>,
kyungmin.park@...sung.com, mchehab@...nel.org, kgene@...nel.org,
krzk@...nel.org, linux-media@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/11] media: exynos4-is: Correct parallel port probing
Hi Sylwester,
On 2020-07-08 9:15 a.m., Sylwester Nawrocki wrote:
> Hi,
>
> On 26.04.2020 04:26, Jonathan Bakker wrote:
>> According to the binding doc[1], port A should be reg = 0
>> and port B reg = 1. Unfortunately, the driver was treating 0
>> as invalid and 1 as camera port A. Match the binding doc and
>> make 0=A and 1=B.
>>
>> [1] Documentation/devicetree/bindings/media/samsung-fimc.txt
>
> Thank you for correcting this. I would prefer to correct the binding
> documentation instead, so it says reg=1 for A and reg=2 for B.
> Then it would also match what we have in dts for Goni and
> enum fimc_input in include/media/drv-intf/exynos-fimc.h
No problem, that works for me. I'll drop this patch and replace it with one
changing the documentation.
>
>
Thanks,
Jonathan
Powered by blists - more mailing lists