linux-kernel - Re: [PATCH v4] nbd: Fix memory leak in nbd_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200708203204.GB35321@sol.localdomain>
Date:   Wed, 8 Jul 2020 13:32:04 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Zheng Bin <zhengbin13@...wei.com>
Cc:     mchristi@...hat.com, josef@...icpanda.com, axboe@...nel.dk,
        navid.emamdoost@...il.com, linux-block@...r.kernel.org,
        nbd@...er.debian.org, linux-kernel@...r.kernel.org,
        yi.zhang@...wei.com
Subject: Re: [PATCH v4] nbd: Fix memory leak in nbd_add_socket

On Mon, Jun 29, 2020 at 09:23:49AM +0800, Zheng Bin wrote:
> When adding first socket to nbd, if nsock's allocation failed, the data
> structure member "config->socks" was reallocated, but the data structure
> member "config->num_connections" was not updated. A memory leak will occur
> then because the function "nbd_config_put" will free "config->socks" only
> when "config->num_connections" is not zero.
> 
> Fixes: 03bf73c315ed ("nbd: prevent memory leak")
> Reported-by: syzbot+934037347002901b8d2a@...kaller.appspotmail.com
> Signed-off-by: Zheng Bin <zhengbin13@...wei.com>
> ---

Reviewed-by: Eric Biggers <ebiggers@...gle.com>