linux-kernel - Re: [PATCH v4] nbd: Fix memory leak in nbd_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a7597c2-2d51-8382-5b60-73cd39e55fda@kernel.dk>
Date:   Wed, 8 Jul 2020 15:42:35 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Zheng Bin <zhengbin13@...wei.com>, mchristi@...hat.com,
        ebiggers@...nel.org, josef@...icpanda.com,
        navid.emamdoost@...il.com, linux-block@...r.kernel.org,
        nbd@...er.debian.org, linux-kernel@...r.kernel.org
Cc:     yi.zhang@...wei.com
Subject: Re: [PATCH v4] nbd: Fix memory leak in nbd_add_socket

On 6/28/20 7:23 PM, Zheng Bin wrote:
> When adding first socket to nbd, if nsock's allocation failed, the data
> structure member "config->socks" was reallocated, but the data structure
> member "config->num_connections" was not updated. A memory leak will occur
> then because the function "nbd_config_put" will free "config->socks" only
> when "config->num_connections" is not zero.

Applied, thanks.

-- 
Jens Axboe