linux-kernel - Re: [PATCH 3/4] firmware: arm_scmi: Fix scmi_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Jul 2020 22:38:08 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Cristian Marussi <cristian.marussi@....com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH 3/4] firmware: arm_scmi: Fix scmi_event_header fields typing

On Wed, Jul 8, 2020 at 2:24 PM Cristian Marussi
<cristian.marussi@....com> wrote:
>
> Drop size_t in favour of fixed size u32 for consistency and shuffle
> around fields definitions to minimize implicit padding.
>
> Signed-off-by: Cristian Marussi <cristian.marussi@....com>

As you still have implicit padding at the end, I'd either make
that explicit now, or leave the __packed attribute.

The payld_sz is not actually force to be misaligned with the
reordered layout, which is what's most important.

     Arnd