linux-kernel - Re: [PATCH 4/4] firmware: arm_scmi: Remove fixed size typing from event reports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0V7TpCV_VOhRAN7V1Bo2_3UXs6pcv-bVLOg1+x=H4buQ@mail.gmail.com>
Date:   Wed, 8 Jul 2020 22:39:57 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Cristian Marussi <cristian.marussi@....com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH 4/4] firmware: arm_scmi: Remove fixed size typing from
 event reports

On Wed, Jul 8, 2020 at 2:25 PM Cristian Marussi
<cristian.marussi@....com> wrote:
>
> Event reports are used to convey information describing events to the
> registered user-callbacks: they are necessarily derived from the underlying
> raw SCMI events' messages but they are not meant to expose or directly
> mirror any of those messages data layout, which belong to the protocol
> layer.
>
> Using fixed size fields mirroring messages structure is at odd with this:
> get rid of them using more generic, equivalent, typing.
>
> Signed-off-by: Cristian Marussi <cristian.marussi@....com>

Ok, I was expecting you would go with fixed-size structures without
implied padding, but either way makes it more consistent, so this
version is good, too.

       Arnd