linux-kernel - Re: [PATCH] security: selinux: ss: conditional.c fixed a checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 9 Jul 2020 14:09:57 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Ethan Edwards <ethancarteredwards@...il.com>
Cc:     Stephen Smalley <stephen.smalley.work@...il.com>,
        selinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] security: selinux: ss: conditional.c fixed a checkpatch warning

On Thu, Jul 9, 2020 at 9:11 AM Ethan Edwards
<ethancarteredwards@...il.com> wrote:
>
> `sizeof buf` changed to `sizeof(buf)`
>
> Signed-off-by: Ethan Edwards <ethancarteredwards@...il.com>
> ---
>  security/selinux/ss/conditional.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Why are you reposting this when I applied your original patch last week?

https://lore.kernel.org/selinux/CAHC9VhSakA7V99+tkvLLZHohiupWmjSFxSZLWZT4-Gwr5Cc-XA@mail.gmail.com

> diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c
> index 0cc7cdd58465..90a2f5927e55 100644
> --- a/security/selinux/ss/conditional.c
> +++ b/security/selinux/ss/conditional.c
> @@ -215,7 +215,7 @@ int cond_read_bool(struct policydb *p, struct hashtab *h, void *fp)
>         if (!booldatum)
>                 return -ENOMEM;
>
> -       rc = next_entry(buf, fp, sizeof buf);
> +       rc = next_entry(buf, fp, sizeof(buf));
>         if (rc)
>                 goto err;
>
> @@ -416,7 +416,7 @@ int cond_read_list(struct policydb *p, void *fp)
>         u32 i, len;
>         int rc;
>
> -       rc = next_entry(buf, fp, sizeof buf);
> +       rc = next_entry(buf, fp, sizeof(buf));
>         if (rc)
>                 return rc;
>
> --
> 2.27.0
>


-- 
paul moore
www.paul-moore.com