linux-kernel - Re: [PATCH 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcE9skpqa32bZ4AAcOa08WYSqqZodnveLSF+sZej5KnWw@mail.gmail.com>
Date:   Thu, 9 Jul 2020 23:50:59 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Eddie James <eajames@...ux.ibm.com>
Cc:     Linux LED Subsystem <linux-leds@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>, Dan Murphy <dmurphy@...com>,
        Pavel Machek <pavel@....cz>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        vishwa@...ux.ibm.com
Subject: Re: [PATCH 2/2] leds: pca955x: Add an IBM software implementation of
 the PCA9552 chip

On Thu, Jul 9, 2020 at 11:16 PM Eddie James <eajames@...ux.ibm.com> wrote:
>
> IBM created an implementation of the PCA9552 on a PIC16F
> microcontroller. The I2C device addresses are different from the
> hardware PCA9552, so add a new compatible string and associated
> platform data to be able to probe this device.

This is weird. I would rather expect ibm prefix with corresponding part number.

> +       pca9552_ibm,

> +       [pca9552_ibm] = {

> +       { "pca9552-ibm", pca9552_ibm },

> +       { .compatible = "nxp,pca9552-ibm", .data = (void *)pca9552_ibm },


-- 
With Best Regards,
Andy Shevchenko