linux-kernel - Re: [printk] 18a2dc6982: ltp.kmsg01.fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874kqhm1v8.fsf@jogness.linutronix.de>
Date:   Thu, 09 Jul 2020 12:20:35 +0206
From:   John Ogness <john.ogness@...utronix.de>
To:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        kernel test robot <rong.a.chen@...el.com>
Cc:     Petr Mladek <pmladek@...e.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andrea Parri <parri.andrea@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Paul McKenney <paulmck@...nel.org>, kexec@...ts.infradead.org,
        linux-kernel@...r.kernel.org, lkp@...ts.01.org
Subject: Re: [printk] 18a2dc6982: ltp.kmsg01.fail

On 2020-07-09, Sergey Senozhatsky <sergey.senozhatsky@...il.com> wrote:
> On (20/07/09 15:14), kernel test robot wrote:
> [..]
>
> Took me a while to find the FAIL-ed test:
>
>> kmsg01.c:393: INFO: TEST: read returns EPIPE when messages get overwritten
>> kmsg01.c:398: INFO: first seqno: 0
>> kmsg01.c:411: INFO: first seqno now: 881
>> kmsg01.c:425: FAIL: read returned: 77: SUCCESS (0)
>
> So this is seq number related
> https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/logging/kmsg/kmsg01.c#L383

Excellent test.

Since the messages are above the expected average size, the dataring is
wrapping before the descriptor ring. This means that the initial
descriptors are still there, but their data is gone. Initially I would
generate an EPIPE for this, but it was changed. Here is the thread [0]
we had about this.

I have some ideas how to correctly handle this. Let me try some
alternatives and post a proposed solution.

John Ogness

[0] https://lkml.kernel.org/r/20200213090757.GA36551@google.com