linux-kernel - RE: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB3819D07348C347B5BB8F86C085640@DM6PR11MB3819.namprd11.prod.outlook.com>
Date:   Thu, 9 Jul 2020 10:14:16 +0000
From:   "Wu, Hao" <hao.wu@...el.com>
To:     "Xu, Yilun" <yilun.xu@...el.com>
CC:     "mdf@...nel.org" <mdf@...nel.org>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "trix@...hat.com" <trix@...hat.com>,
        "lgoncalv@...hat.com" <lgoncalv@...hat.com>,
        Matthew Gerlach <matthew.gerlach@...ux.intel.com>,
        "Weight, Russell H" <russell.h.weight@...el.com>
Subject: RE: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000

> On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote:
> > > Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
> > >
> > > Add PCIe Device ID for Intel FPGA PAC N3000.
> > >
> > > Signed-off-by: Wu Hao <hao.wu@...el.com>
> > > Signed-off-by: Xu Yilun <yilun.xu@...el.com>
> > > Signed-off-by: Matthew Gerlach <matthew.gerlach@...ux.intel.com>
> > > Signed-off-by: Russ Weight <russell.h.weight@...el.com>
> > > ---
> > >  drivers/fpga/dfl-pci.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> > > index 73b5153..824aecf 100644
> > > --- a/drivers/fpga/dfl-pci.c
> > > +++ b/drivers/fpga/dfl-pci.c
> > > @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
> > >  #define PCIE_DEVICE_ID_PF_INT_5_X0xBCBD
> > >  #define PCIE_DEVICE_ID_PF_INT_6_X0xBCC0
> > >  #define PCIE_DEVICE_ID_PF_DSC_1_X0x09C4
> > > +#define PCIE_DEVICE_ID_PF_PAC_N3000 0x0B30
> >
> > Should we drop _PF_ here? and also do you want _INTEL_ here?
> 
> I think we could keep _PF_, also there is no need to support VF of pac
> n3000 in product now, but it does exist (ID: 0x0b31).
> 
> And add _INTEL_ is good to me.
> 
> Then how about this one:
>   #define PCIE_DEVICE_ID_PF_INTEL_PAC_N3000	0x0B30

I am just considering the alignment with ids defined in include/linux/pci_ids.h
So drop _PF_ before _INTEL_ would be better? : )

Thanks
Hao