linux-kernel - RE: [PATCH] service_layers: osunixmap: Remove unnecessary brackets in acpi_os_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR11MB3256999B714C7F5598E3213687640@BYAPR11MB3256.namprd11.prod.outlook.com>
Date:   Thu, 9 Jul 2020 14:49:17 +0000
From:   "Moore, Robert" <robert.moore@...el.com>
To:     Xu Wang <vulab@...as.ac.cn>,
        "Kaneda, Erik" <erik.kaneda@...el.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] service_layers: osunixmap: Remove unnecessary brackets in
 acpi_os_map_memory()

-		return (NULL);
+		return NULL;

This is the ACPICA coding standard, and it does not affect anything.
Bob

-----Original Message-----
From: Xu Wang <vulab@...as.ac.cn> 
Sent: Thursday, July 09, 2020 1:08 AM
To: Moore, Robert <robert.moore@...el.com>; Kaneda, Erik <erik.kaneda@...el.com>; Wysocki, Rafael J <rafael.j.wysocki@...el.com>; lenb@...nel.org; vulab@...as.ac.cn; linux-acpi@...r.kernel.org; devel@...ica.org
Cc: linux-kernel@...r.kernel.org
Subject: [PATCH] service_layers: osunixmap: Remove unnecessary brackets in acpi_os_map_memory()

Remove extra brackets.

Signed-off-by: Xu Wang <vulab@...as.ac.cn>
---
 tools/power/acpi/os_specific/service_layers/osunixmap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/power/acpi/os_specific/service_layers/osunixmap.c b/tools/power/acpi/os_specific/service_layers/osunixmap.c
index c565546e85bc..52f3e70b5c81 100644
--- a/tools/power/acpi/os_specific/service_layers/osunixmap.c
+++ b/tools/power/acpi/os_specific/service_layers/osunixmap.c
@@ -70,7 +70,7 @@ void *acpi_os_map_memory(acpi_physical_address where, acpi_size length)
 	fd = open(SYSTEM_MEMORY, O_RDONLY | O_BINARY);
 	if (fd < 0) {
 		fprintf(stderr, "Cannot open %s\n", SYSTEM_MEMORY);
-		return (NULL);
+		return NULL;
 	}
 
 	/* Align the offset to use mmap */
@@ -85,7 +85,7 @@ void *acpi_os_map_memory(acpi_physical_address where, acpi_size length)
 	if (mapped_memory == MAP_FAILED) {
 		fprintf(stderr, "Cannot map %s\n", SYSTEM_MEMORY);
 		close(fd);
-		return (NULL);
+		return NULL;
 	}
 
 	close(fd);
-- 
2.17.1