lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Jul 2020 16:22:10 +0800 From: Baolin Wang <baolin.wang@...ux.alibaba.com> To: axboe@...nel.dk Cc: ming.lei@...hat.com, baolin.wang7@...il.com, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] blk-mq: Remove unnecessary local variable Hi, On Sat, Jul 04, 2020 at 03:26:14PM +0800, Baolin Wang wrote: > Remove unnecessary local variable 'ret' in blk_mq_dispatch_hctx_list(). > A gentle ping? > Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com> > --- > block/blk-mq-sched.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c > index 1c52e56a19b1..b8db72cf1043 100644 > --- a/block/blk-mq-sched.c > +++ b/block/blk-mq-sched.c > @@ -96,7 +96,6 @@ static bool blk_mq_dispatch_hctx_list(struct list_head *rq_list) > struct request *rq; > LIST_HEAD(hctx_list); > unsigned int count = 0; > - bool ret; > > list_for_each_entry(rq, rq_list, queuelist) { > if (rq->mq_hctx != hctx) { > @@ -108,8 +107,7 @@ static bool blk_mq_dispatch_hctx_list(struct list_head *rq_list) > list_splice_tail_init(rq_list, &hctx_list); > > dispatch: > - ret = blk_mq_dispatch_rq_list(hctx, &hctx_list, count); > - return ret; > + return blk_mq_dispatch_rq_list(hctx, &hctx_list, count); > } > > #define BLK_MQ_BUDGET_DELAY 3 /* ms units */ > -- > 2.17.1
Powered by blists - more mailing lists