[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200710082304.GB29262@VM20190228-100.tbsite.net>
Date: Fri, 10 Jul 2020 16:23:04 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: axboe@...nel.dk
Cc: ming.lei@...hat.com, baolin.wang7@...il.com,
linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blk-mq: Remove unnecessary validation before calling
blk_mq_sched_completed_request()
Hi,
On Sat, Jul 04, 2020 at 03:28:21PM +0800, Baolin Wang wrote:
> We've already validated the 'q->elevator' before calling ->ops.completed_request()
> in blk_mq_sched_completed_request(), thus no need to validate rq->internal_tag again,
> and remove it.
A gentle ping?
>
> Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> ---
> block/blk-mq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index abcf590f6238..78572b2e1675 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -550,8 +550,7 @@ inline void __blk_mq_end_request(struct request *rq, blk_status_t error)
> blk_stat_add(rq, now);
> }
>
> - if (rq->internal_tag != BLK_MQ_NO_TAG)
> - blk_mq_sched_completed_request(rq, now);
> + blk_mq_sched_completed_request(rq, now);
>
> blk_account_io_done(rq, now);
>
> --
> 2.17.1
Powered by blists - more mailing lists