linux-kernel - Re: [PATCH] pinctrl: initialise nsp-mux earlier.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5d97c2a-95fb-e02d-029a-c19ceb1b166f@gmail.com>
Date:   Sat, 11 Jul 2020 14:09:09 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     Mark Tomlinson <Mark.Tomlinson@...iedtelesis.co.nz>,
        "ray.jui@...adcom.com" <ray.jui@...adcom.com>,
        "bcm-kernel-feedback-list@...adcom.com" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "sbranden@...adcom.com" <sbranden@...adcom.com>,
        "rjui@...adcom.com" <rjui@...adcom.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: initialise nsp-mux earlier.



On 7/11/2020 2:07 PM, Linus Walleij wrote:
> On Wed, Jul 1, 2020 at 6:44 AM Florian Fainelli <f.fainelli@...il.com> wrote:
>> On 6/30/2020 9:37 PM, Mark Tomlinson wrote:
> 
>>> That was one of my thoughts too. I found someone had tried that
>>> earlier, but it was rejected:
>>>
>>>
>>> https://patchwork.ozlabs.org/project/linux-gpio/patch/1516566774-1786-1-git-send-email-david@lechnology.com/
>>
>> clk or reset APIs do not complain loudly on EPROBE_DEFER, it seems to me
>> that GPIO should follow here. Also, it does look like Linus was in
>> agreement in the end, not sure why it was not applied though.
> 
> I never got an updated patch. My last message was:
> 
>>> so you mean something like this?
>>>
>>> if (err == -EPROBE_DEFER)
>>>         dev_info(dev, "deferring probe\n")
>>> else
>>>         dev_err(dev, "... failed to register\n")
>>
>> Yes exactly.
> 
> Patches welcome :D

Not sure how useful the dev_info(dev, "deferring probe\n") is nowadays
given that the device driver core will show which devices are on the
probe deferral list, maybe we can turn this into a dev_dbg() instead?
-- 
Florian