linux-kernel - Re: [PATCH] Revert "thermal: mediatek: fix register index error"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F97EEB5B-958A-4CA3-A3F2-7668B8E778FA@public-files.de>
Date:   Sun, 12 Jul 2020 19:16:43 +0200
From:   Frank Wunderlich <frank-w@...lic-files.de>
To:     linux-mediatek@...ts.infradead.org,
        Matthias Brugger <matthias.bgg@...il.com>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        linux-kernel@...r.kernel.org,
        Amit Kucheria <amit.kucheria@...durent.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Zhang Rui <rui.zhang@...el.com>
CC:     drinkcat@...omium.org, linux-pm@...r.kernel.org,
        Michael Kao <michael.kao@...iatek.com>,
        Eduardo Valentin <edubezval@...il.com>, hsinyi@...omium.org,
        Collabora Kernel ML <kernel@...labora.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] Revert "thermal: mediatek: fix register index error"

Am 12. Juli 2020 18:55:41 MESZ schrieb Matthias Brugger <matthias.bgg@...il.com>:
>On 10/07/2020 15:58, Matthias Brugger wrote:
>Even more interesting, with and without the revert the
>thermal 
>sensor returns always zero, so it seems it never actually worked.

The thermal driver works on bananapi-r2 till 5.6. Something in 5.7.0 breaks it, but it's not caused by the reverted commit or the revert...neither the commit nor the revert has any effect on r2 (no crash/error/functionality change).

Additionally there is no difference in mtk-thermal.c between working 5.6 and non-working 5.7. Thermal-merge in 5.7-rc1 shows also nothing suspicious and dts(i) is also same in relevant parts.

Maybe anyone of the recipients have an idea about the broken mt7623/mt2701 functionality.
regards Frank