linux-kernel - Re: [RFC v2 5/5] perf/tools/pmu_events/powerpc: Add hv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200712185543.GC147742@krava>
Date:   Sun, 12 Jul 2020 20:55:43 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Kajol Jain <kjain@...ux.ibm.com>
Cc:     acme@...nel.org, peterz@...radead.org, mingo@...hat.com,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        pc@...ibm.com, namhyung@...nel.org, ak@...ux.intel.com,
        yao.jin@...ux.intel.com, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org, irogers@...gle.com,
        maddy@...ux.ibm.com, ravi.bangoria@...ux.ibm.com,
        anju@...ux.vnet.ibm.com, kan.liang@...ux.intel.com,
        nasastry@...ibm.com
Subject: Re: [RFC v2 5/5] perf/tools/pmu_events/powerpc: Add hv_24x7 core
 level metric events

On Tue, Jul 07, 2020 at 05:53:14PM +0530, Kajol Jain wrote:
> This patch adds hv_24x7 core level events in nest_metric.json file
> and also add PerChip/PerCore field in metric events.
> 
> Result:
> 
> power9 platform:
> 
> command:# ./perf stat --metric-only -M PowerBUS_Frequency -C 0 -I 1000
>      1.000070601                        1.9                        2.0
>      2.000253881                        2.0                        1.9
>      3.000364810                        2.0                        2.0
> 
> Signed-off-by: Kajol Jain <kjain@...ux.ibm.com>
> ---
>  .../arch/powerpc/power9/nest_metrics.json       | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json b/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json
> index c121e526442a..2a471cb5dd7a 100644
> --- a/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json
> +++ b/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json
> @@ -3,17 +3,26 @@
>          "MetricExpr": "(hv_24x7@...MCS01_128B_RD_DISP_PORT01\\,chip\\=?@ + hv_24x7@...MCS01_128B_RD_DISP_PORT23\\,chip\\=?@ + hv_24x7@...MCS23_128B_RD_DISP_PORT01\\,chip\\=?@ + hv_24x7@...MCS23_128B_RD_DISP_PORT23\\,chip\\=?@)",
>          "MetricName": "Memory_RD_BW_Chip",
>          "MetricGroup": "Memory_BW",
> -        "ScaleUnit": "1.6e-2MB"
> +        "ScaleUnit": "1.6e-2MB",
> +	"AggregationMode": "PerChip"
>      },
>      {
>  	"MetricExpr": "(hv_24x7@...MCS01_128B_WR_DISP_PORT01\\,chip\\=?@ + hv_24x7@...MCS01_128B_WR_DISP_PORT23\\,chip\\=?@ + hv_24x7@...MCS23_128B_WR_DISP_PORT01\\,chip\\=?@ + hv_24x7@...MCS23_128B_WR_DISP_PORT23\\,chip\\=?@ )",
>          "MetricName": "Memory_WR_BW_Chip",
>          "MetricGroup": "Memory_BW",
> -        "ScaleUnit": "1.6e-2MB"
> +        "ScaleUnit": "1.6e-2MB",
> +	"AggregationMode": "PerChip"

please keep the same indentation, also below

jirka

>      },
>      {
>  	"MetricExpr": "(hv_24x7@...PB_CYC\\,chip\\=?@ )",
>          "MetricName": "PowerBUS_Frequency",
> -        "ScaleUnit": "2.5e-7GHz"
> -    }
> +        "ScaleUnit": "2.5e-7GHz",
> +	"AggregationMode": "PerChip"
> +    },
> +    {
> +	"MetricExpr": "(hv_24x7@..._CS_32MHZ_CYC\\,domain\\=3\\,core\\=?@ )",
> +        "MetricName": "CPM_CS_32MHZ_CYC",
> +        "ScaleUnit": "1MHz",
> +	"AggregationMode": "PerCore"
> +     }
>  ]
> -- 
> 2.26.2
>