linux-kernel - Re: arch/mips/alchemy/devboards/db1300.c:(.text.db1300_wm97xx_probe+0x2c): undefined reference to `wm97xx_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOLZvyEFSfYqry2N2wGMzLg36BZRXgnsnQaZPytWmvMUy=ZYtQ@mail.gmail.com>
Date:   Mon, 13 Jul 2020 13:07:14 +0200
From:   Manuel Lauss <manuel.lauss@...il.com>
To:     Jiaxun Yang <jiaxun.yang@...goat.com>
Cc:     Linux-MIPS <linux-mips@...r.kernel.org>, kbuild-all@...ts.01.org,
        LKML <linux-kernel@...r.kernel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Subject: Re: arch/mips/alchemy/devboards/db1300.c:(.text.db1300_wm97xx_probe+0x2c):
 undefined reference to `wm97xx_config_gpio'

Hello all,

On Mon, Jul 13, 2020 at 3:29 AM Jiaxun Yang <jiaxun.yang@...goat.com> wrote:
>
> 在 2020/7/12 18:01, kernel test robot 写道:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   0aea6d5c5be33ce94c16f9ab2f64de1f481f424b
> > commit: ff487d41036035376e47972c7c522490b839ab37 MIPS: Truncate link address into 32bit for 32bit kernel
> > date:   9 weeks ago
> > config: mips-randconfig-c023-20200712 (attached as .config)
> > compiler: mipsel-linux-gcc (GCC) 9.3.0
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@...el.com>
> >
> > All errors (new ones prefixed by >>):
> >
> >     mipsel-linux-ld: arch/mips/alchemy/devboards/db1300.o: in function `db1300_wm97xx_probe':
>
> Well this seems unrelated with my changes.

Yes,

> Just wonder if alchemy still alive?

My test hardware still works

> Should I fix it or just drop alchemy support?

Something like this should fix it.  I never tested randconfig because I find
it kind of pointless for these kinds of specialized boards/systems.

diff --git a/arch/mips/alchemy/devboards/db1300.c
b/arch/mips/alchemy/devboards/db1300.c
index 8ac1f56ee57d..9c7736d88bce 100644
--- a/arch/mips/alchemy/devboards/db1300.c
+++ b/arch/mips/alchemy/devboards/db1300.c
@@ -746,6 +746,7 @@ static struct wm97xx_mach_ops db1300_wm97xx_ops = {

 static int db1300_wm97xx_probe(struct platform_device *pdev)
 {
+#if IS_ENABLED(CONFIG_TOUCHSCREEN_WM97XX)
        struct wm97xx *wm = platform_get_drvdata(pdev);

        /* external pendown indicator */
@@ -761,6 +762,9 @@ static int db1300_wm97xx_probe(struct platform_device *pdev)
        wm->pen_irq = DB1300_AC97_PEN_INT;

        return wm97xx_register_mach_ops(wm, &db1300_wm97xx_ops);
+#else
+       return -ENODEV;
+#endif
 }


Manuel