linux-kernel - Re: [PATCH v2] fpga: dfl: pci: add device id for Intel FPGA PAC N3000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200714060108.GA27430@yilunxu-OptiPlex-7050>
Date:   Tue, 14 Jul 2020 14:01:08 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Tom Rix <trix@...hat.com>
Cc:     mdf@...nel.org, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org, lgoncalv@...hat.com,
        Wu Hao <hao.wu@...el.com>,
        Matthew Gerlach <matthew.gerlach@...ux.intel.com>,
        Russ Weight <russell.h.weight@...el.com>
Subject: Re: [PATCH v2] fpga: dfl: pci: add device id for Intel FPGA PAC N3000

On Mon, Jul 13, 2020 at 07:36:26AM -0700, Tom Rix wrote:
> 
> > @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
> >  #define PCIE_DEVICE_ID_PF_INT_5_X	0xBCBD
> >  #define PCIE_DEVICE_ID_PF_INT_6_X	0xBCC0
> >  #define PCIE_DEVICE_ID_PF_DSC_1_X	0x09C4
> > +#define PCIE_DEVICE_ID_INTEL_PAC_N3000	0x0B30
> 
> My point about consistency.  These are all intel  and all should have their pf parts removed.
> 
>  #define PCIE_DEVICE_ID_INTEL_INT_5_X	0xBCBD
>  #define PCIE_DEVICE_ID_INTEL_INT_6_X	0xBCC0
>  #define PCIE_DEVICE_ID_INTEL_DSC_1_X	0x09C4
> 
> Let's revisit this for the d5005.

I agree that we should be consistent on the naming. I think we could
reconsider the naming of previous cards and submit a new patch for them.

> 
> trix
>