linux-kernel - Re: [PATCH v2 22/24] scsi: aic7xxx: aic79xx_osm: Remove unused variables 'wait' and 'paused'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Jul 2020 09:47:25 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Lee Jones <lee.jones@...aro.org>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        Hannes Reinecke <hare@...e.com>
Subject: Re: [PATCH v2 22/24] scsi: aic7xxx: aic79xx_osm: Remove unused
 variables 'wait' and 'paused'

On 7/13/20 9:59 AM, Lee Jones wrote:
> It looks like they have never actually been used.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_dev_reset’:
>  drivers/scsi/aic7xxx/aic79xx_osm.c:782:9: warning: variable ‘wait’ set but not used [-Wunused-but-set-variable]
>  drivers/scsi/aic7xxx/aic79xx_osm.c:781:9: warning: variable ‘paused’ set but not used [-Wunused-but-set-variable]
> 
> Cc: Hannes Reinecke <hare@...e.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/scsi/aic7xxx/aic79xx_osm.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c
> index 9235b6283c0b3..8e43ff86e0a60 100644
> --- a/drivers/scsi/aic7xxx/aic79xx_osm.c
> +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c
> @@ -775,16 +775,13 @@ ahd_linux_dev_reset(struct scsi_cmnd *cmd)
>  	struct scb *reset_scb;
>  	u_int  cdb_byte;
>  	int    retval = SUCCESS;
> -	int    paused;
> -	int    wait;
>  	struct	ahd_initiator_tinfo *tinfo;
>  	struct	ahd_tmode_tstate *tstate;
>  	unsigned long flags;
>  	DECLARE_COMPLETION_ONSTACK(done);
>  
>  	reset_scb = NULL;
> -	paused = FALSE;
> -	wait = FALSE;
> +
>  	ahd = *(struct ahd_softc **)cmd->device->host->hostdata;
>  
>  	scmd_printk(KERN_INFO, cmd,
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@...e.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer