linux-kernel - Re: [PATCH v2 21/24] scsi: aic7xxx: aic79xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9f25f97-ec01-f1b1-ca4e-074838141606@suse.de>
Date:   Tue, 14 Jul 2020 09:47:43 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Lee Jones <lee.jones@...aro.org>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        Hannes Reinecke <hare@...e.com>
Subject: Re: [PATCH v2 21/24] scsi: aic7xxx: aic79xx_osm: Remove unused
 variable 'ahd'

On 7/13/20 9:59 AM, Lee Jones wrote:
> Hasn't been used since 2005.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_slave_configure’:
>  drivers/scsi/aic7xxx/aic79xx_osm.c:703:20: warning: variable ‘ahd’ set but not used [-Wunused-but-set-variable]
> 
> Cc: Hannes Reinecke <hare@...e.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/scsi/aic7xxx/aic79xx_osm.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c
> index dc4fe334efd01..9235b6283c0b3 100644
> --- a/drivers/scsi/aic7xxx/aic79xx_osm.c
> +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c
> @@ -700,9 +700,6 @@ ahd_linux_slave_alloc(struct scsi_device *sdev)
>  static int
>  ahd_linux_slave_configure(struct scsi_device *sdev)
>  {
> -	struct	ahd_softc *ahd;
> -
> -	ahd = *((struct ahd_softc **)sdev->host->hostdata);
>  	if (bootverbose)
>  		sdev_printk(KERN_INFO, sdev, "Slave Configure\n");
>  
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@...e.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer